Add test-data-resolution to nextflow/cwl-to-galaxy with source-specific resolvers (#348)#350
Open
jmchilton wants to merge 2 commits into
Open
Add test-data-resolution to nextflow/cwl-to-galaxy with source-specific resolvers (#348)#350jmchilton wants to merge 2 commits into
jmchilton wants to merge 2 commits into
Conversation
implement-galaxy-workflow-test requires test-data-refs, but the nextflow-to-galaxy and cwl-to-galaxy spines had no phase producing it — the phase was uncompletable by composition (validator warned on the unproduced consumed artifact). Insert a test-data-resolution [branch] (chain: find-test-data -> user-supplied) after the draft loop, matching the shape already in paper-to-galaxy and interview-to-galaxy. Regenerate the two assembled harnesses. Fixes #348 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…anch find-test-data is a search mold — the wrong first leg for nextflow/cwl, whose summaries already declare their own test fixtures (nextflow test_fixtures: role/url/sha1/filetype; cwl tests[]: job_path + expected_outputs). Mirror the paper-to-test-data pattern: add source-specific resolvers that map declared fixtures onto the Galaxy interface and emit test-data-refs, deferring to find-test-data (search) only for unresolved inputs, then user-supplied. - New molds nextflow-to-test-data, cwl-to-test-data (+ casts). - test-data-resolution chains now: <source>-to-test-data -> find-test-data -> user-supplied. - Regenerate harnesses, Index/Dashboard; update HARNESS_PIPELINES/MOLDS docs. Refs #348 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened by Claude (AI assistant) on behalf of @jmchilton.
Fixes #348.
Problem
implement-galaxy-workflow-testrequirestest-data-refs, but thenextflow-to-galaxyandcwl-to-galaxyspines had no phase producing it — the phase was uncompletable by composition (the Pipeline validator warned on the unproduced consumed artifact).Design
Rather than wire these spines straight to the generic
find-test-datasearch mold, this restores the patternpaper-to-galaxyalready uses (paper-to-test-data → find-test-data → user-supplied).find-test-datasearches IWC/public sources — the wrong first move for nextflow/cwl, whose summaries already declare their own test fixtures:summary-nextflow.test_fixtures/nf_tests[]— each input arole+url/path+sha1+filetypesummary-cwl.tests[]— each case ajob_path(naming inputs) +expected_outputsSo two new source-specific resolvers map those declared fixtures onto the Galaxy interface and emit
test-data-refs, deferring tofind-test-data(search) only for inputs they can't resolve:nextflow-to-test-data(axis: source-specific, source: nextflow)cwl-to-test-data(axis: source-specific, source: cwl)test-data-resolutionchains become:This also dissolves a diamond-overlap: the resolver reads declared fixtures for data, the test-plan mold reads them for assertions — orthogonal, and exactly how paper already works.
Changes
nextflow-to-test-data,cwl-to-test-data(+ casts).test-data-resolutionbranch chains fronted with the source-specific resolver.Index.md/Dashboard.md.docs/HARNESS_PIPELINES.mdanddocs/MOLDS.md.Verification
npm run validate→ 0 errors; thetest-data-refsunproduced-artifact warning is gone for both spines.make check-generated→ clean.assemble-pipeline --checkfor both spines → clean against committed cast state.Notes
index.md+ cast only (noeval.md/scenarios.mdyet), matching thepaper-to-test-dataprecedent; those come with first test-drives.update-interview-to-galaxyshows the same validator warning but is intentionally left out of scope — itsharness_notesdocumenttest-data-refscoming from the edited workflow's baseline fixtures.docs/MOLDS.md's "34 candidate Molds total" is a frozen design-era count (actual dirs: 47), unrelated to this change.🤖 Generated with Claude Code