Repository navigation
fix(ci): unbreak the lint gate - #1
Merged
Merged
Conversation
golangci-lint-action v8 dropped support for the pinned v2.0.0, so the lint step has been erroring out on every push since the action was upgraded — CI was red on main and the linter never actually ran. Bump to v2.1.0, the oldest version the action still accepts. With the gate running again it flagged one real issue: the tokenizer discarded the error from fmt.Sscanf, so a literal it failed to parse became 0 and produced a confidently wrong answer — precisely what an engine that computes every drill answer in Go exists to prevent. Use strconv.ParseFloat, whose only reachable failure here (overflow) still returns the correctly-signed infinity that Eval already rejects. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
v2.1.0 installs but is built with Go 1.24, and golangci-lint refuses to load a config whose targeted Go version (go.mod says 1.26.3) is newer than its own toolchain. v2.12.2 is built with go1.26 and is the version this repo's lint has been passing against locally. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI has been red on main since golangci-lint-action v8 stopped supporting the pinned
v2.0.0. The lint step errored during install, so the linter never ran on any recent commit.v2.1.0(oldest still accepted by the action)fmt.Sscanfin the mathgen tokenizer, where a failed parse silently became0— a wrong-answer path in the engine whose premise is that code, not the model, owns the arithmetic🤖 Generated with Claude Code