Refer to strategies exclusively by labels in pygambit - #1096
Merged
Conversation
This removes `__getitem__` from games, which was an implicit way to access the strategic form, including deprecated integer index. Instead, this introduces `get_outcome` and `get_payoffs`, which allows more explicit access via proper strategy profile mappings.
Now that all strategies must have nonempty, unique labels (for a player), this collection simply iterates over the strategy labels rather than materialising objects referring to internals of the game representation.
…vidual object handles.
…ced entirely by labels
…part of test suite.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements several interlocking changes to
pygambitto standardise how strategies are referenced.Strategyobject, which actually held a reference to the underlying C++ object, has been removed, in line with overall plans for Gambit 17.make_outcome, the semi-undocumented access to the strategic form via the__getitem__operator has been removed, in favour ofget_outcomeandget_payoffsoperations on the game.