Reworking of information set and event concepts in pygambit - #1099
Merged
Conversation
`pygambit` now distinguishes `Infoset` and `Event` objects. Both are now implemented by anchoring on a representative node (as in union-find). As implemented the representative node is the first one encountered in the information set/event when walking the tree depth-first. Information sets and events are queried via `Game.get_infosets` and `Game.get_events`, respectively. Operations which previously took an information set/event now take a member node (or its label) to indicate the information set/event intended - this does not have to be the "representative node".
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
* Strips the `Action` class down to a simple label and probability. * All other properties were redundant, in that they could be otherwise derived. * `Sequence.actions` is now a tuple of labels rather than Action objects.
This completes the removal of `Action` as an object. Actions are now entirely referenced by their label. To accommodate the additional context required, `Node.prior_action` and `Node.own_prior_action` return a namedtuple `Branch` that includes the relevant ancestor-node context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.