Finalise new outcome API - #1100
Merged
Merged
Conversation
This completes the work initiated with the introduction of `make_outcome`: * `Game.add_outcome`, `Game.delete_outcome`, and `Game.set_outcome` are removed from pygambit, along with the underlying C++ `GameRep::NewOutcome`, `GameRep::DeleteOutcome`, `GameRep::SetOutcome`, and `PureStrategyProfileRep::SetOutcome`. * `MakeOutcomeNull` and `make_outcome_null` are introduced to allow for "un-setting" an outcome * Calling code no longer needs to do bookkeeping on outcomes. Instead, the game object manages the invariant that all outcomes are referred to at least once in the game.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the work initiated with the introduction of
make_outcome:Game.add_outcome,Game.delete_outcome, andGame.set_outcomeare removed from pygambit, along with the underlying C++GameRep::NewOutcome,GameRep::DeleteOutcome,GameRep::SetOutcome, andPureStrategyProfileRep::SetOutcome.MakeOutcomeNullandmake_outcome_nullare introduced to allow for "un-setting" an outcome