Align information set and event terminology - #1112
Open
d-kad wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues closed by this PR
Closes #1109
Description of the changes in this PR
One API change.
MixedBehaviorProfile.infoset_probswas the only information-set accessor thatalso contained the chance player's events;
infoset_valuesandinfoset_regretsnever did.It now covers personal players only, and a new
event_probs(returningEventProbVector) takes the events.beliefscovers chance nodes and is normalised by the event's reach probability.The helper feeding
infoset_probsstill carried its pre-split name and annotation, looking like a leftover frombefore
Eventexisted rather than a deliberate design; happy to revert if needed.Docstrings, error messages, and internal iterators in
behavmixed.pxiare corrected,and
Game.revealno longer assumes an information set.In the GUI, the node-properties dialog, the move-properties dialog, the append/insert move popup,
the drag-and-drop popup, and the hover tooltip all say
Eventat chance nodes.formats.efg.rstdescribes chance-node fields in event terms (the file format is unchanged), andgui.efg.building.rstrecords the chance-player variants of the dialog labels.