fix: shell-quote inferred workspace validation paths#58
Open
fix: shell-quote inferred workspace validation paths#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
npm --prefix ${targetPath} ...,cd ${targetPath} && ...,mvn -f ${targetPath}/pom.xml ...) which were later executed with a shell (-lc), creating a command-injection risk from malicious directory names.Description
shellQuotehelper that POSIX single-quotes values and safely escapes embedded single quotes viavalue.replace(/'/g, "'\"'\"'").shellQuotewhen interpolating nested workspacetargetPathinto inferred package manager commands inbuildWorkspacePackageScriptCommandfornpm,yarn, andpnpmso paths are quoted.shellQuoteforcd-baseduvcommands and for the Maven-fargument ininferWorkspaceTargetDetailsso inferredcdandmvn -finvocations do not allow shell metacharacters to be evaluated.test/validation.test.tsto expect quoted nested paths and add a regression test that constructs a workspace directory containing a semicolon to assert the inferred command is quoted rather than executable as a shell fragment.Testing
npm test -- test/validation.test.tsand the suite passed (1 file, 8 tests passed).npm run typecheckand it completed successfully.Codex Task