fix(build): stop running automatic package-manager bootstrap commands on host#61
Open
fix(build): stop running automatic package-manager bootstrap commands on host#61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pnpm install,uv sync) before Codex runs, which allows arbitrary code execution on the operator's machine.Description
bootstrapActionsfor pnpm and uv inresolveBuildEnvironmentAssessmentand replaced them with explanatorynotesso the assessment still records detection but does not execute installs.pnpm,corepack, anduvto therequiredToolsset in this pre-build assessment path to avoid treating those tools as prerequisites for disabled auto-bootstrap behavior.mvn) inventory logic unchanged and preserved other tool detection and thetoolChecksflow.src/build.tsand only disable/annotate the automatic host-side bootstrap behavior while preserving diagnostics.Testing
npm run typecheckand the TypeScript check completed successfully (tsc --noEmit).npm test -- test/build.test.ts; unit tests exercisedrunBuildand completed but report 2 failing tests in this environment:creates a build run with session and verification artifactsandclassifies missing host tools during verification(these failures appear related to changed verification expectations after disabling auto-bootstrap).Codex Task