fix: prevent repo-configured GitHub command execution in deliver flows#64
Open
fix: prevent repo-configured GitHub command execution in deliver flows#64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
workflows.deliver.github.commandcould point at a local script and be auto-executed during deliver evidence collection (when issue references are inferred), enabling arbitrary code execution under the user runningcstack deliver..js/.ts) viaexecFile, which bypasses sandbox expectations and is unsafe for untrusted repo config.Description
execFilewithout implicitly routing scripts throughnodeinsrc/github.ts(removedresolveCommand).ghbinary by settingghCommand = "gh"instead of usingpolicy.commandinsrc/github.ts.test/deliver.test.tsandtest/ship.test.tsto create a fakeghbinary on a temporaryPATH, set the repo configcommand = "gh"in fixtures, and restorePATHinafterEachfor deterministic behavior.Testing
npx vitest run test/deliver.test.ts -t "fails closed when the default branch cannot be resolved for PR mutation"and it passed.npx vitest run test/ship.test.ts -t "runShip"and it passed.Codex Task