fix(build): block repo-configured verification commands from executing#65
Open
fix(build): block repo-configured verification commands from executing#65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
verificationCommandsthat are executed on the host shell duringcstack build, which allowed arbitrary command execution.Description
workflows.build.verificationCommandsandverification.defaultCommandsinsrc/types.tsandsrc/config.tsso sources are recorded asdefault,user, orrepo.loadConfigto populate the new provenance fields by checkingworkflows.build.verificationCommandsandverification.defaultCommandslocations in parsed documents insrc/config.ts.runBuildinsrc/commands/build.tsto ignore verification commands whose provenance isrepoand only use verification commands fromuserordefaultsources, while keeping fallback semantics between workflow-specific and default commands.Testing
npm test -- test/config.test.ts, which passed.npm run -s typecheck, which passed.npm test -- test/config.test.ts test/build.test.tssurfaced failures intest/build.test.tsduring iterative fixes; the final PR includes only the provenance and build-gating changes and validation above.Codex Task