refactor: validate external adapter boundaries with zod#20
Open
kastriotkastrati wants to merge 1 commit into
Open
refactor: validate external adapter boundaries with zod#20kastriotkastrati wants to merge 1 commit into
kastriotkastrati wants to merge 1 commit into
Conversation
Parse and validate LLM, Slack, and GitHub adapter responses at the door with zod, so downstream code consumes typed values instead of narrowing `unknown` with `as`. - github: lenient looseObject schemas for GraphQL nodes (graphql-schema.ts); ghGraphQL/ghRest take a schema and return Result<z.infer<S>>; normalize, discover-links, adapter, and auth consume typed nodes — drops the Record<string, unknown> threading and the boundary casts. - slack: schemas for Web API replies in adapter.ts + identity.ts. - llm: workersAiResponseSchema in extractText. Parse failure -> Result.Err (or undefined where a Platform port demands it). Schemas declare only consumed fields + passthrough, tolerant of upstream additions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.