Don't build IO#77
Conversation
|
In principle I'm fine with it, but isn't it a breaking change (based on everything we've learnt)? It might be borderline OK to include into v3 if we first make sure everything uses |
|
A breaking change might indeed be the better option, to avoid previously passing workflows suddenly failing. |
|
I note that there are still 78 package using Also, But I am tempted to upgrade all the |
|
I've switched all GAP packages that were using In the meantime, I think the I guess I want to say: I'd be fine with merging this now, and dealing with the potential fallout later. |
|
What's the plan after merging this? Do we keep this in |
|
If one considers this a breaking change, then the proper way to handle this would be to make it v4. Alas, that would require again touching 100s of CI workflows, producing lots of churn, for no good reason. But actually, I consider this removal of a temporary workaround; the initial v3 did not build IO either, we added it as a stop gap because we discovered several broken packages that then affected other "innocent" packages. So my plan would be to put this into v3. If it breaks any packages, so be it. I'll have an eye on https://gap-packages.github.io/status (which already reports a bunch of "broken" packages, but those are mostly for unmaintained / unpublished packages). Then soon I might apply a mass patch again to switch packages to test against just GAP "versions" devel/latest/minimal ; that'll then reveal if we broke anything. |
We've already stopped building IO a few times, but had to revert it every time (see e.g. 1bd4673).
With the release of
build-pkg@v3, building IO (if needed) should become the responsability of that action. This can be done by addingIOeither to theDependencies.TestPackagescomponent inPackageInfo.g, or to theextra-pkgsinput of the action.(Making this a draft PR for now since I'm not sure if we want to merge this right away)