Skip to content

Update minimal version to 4.9.1 and improve log message #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stertooy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update minimal version to 4.9.1 and improve log message #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ you will have to change the inputs accordingly. We also recommend replacing bran
- `latest`: this will use the latest release of GAP. This will **not** point to the latest pre-release if it is more recent
than the latest release.
- `minimal`: this will use oldest version of GAP that is supported by both the GAP package in the current directory, and this
action (which currently means GAP 4.9).
action (which currently means GAP 4.9.1).
- version numbers: e.g. `v4.14.0`, `v4.15.0-beta1`, etc. The leading `v` is optional, the oldest available release is `v4.10.0`.
- incomplete version numbers: e.g. `v4`, `v4.10`, etc. These will be expanded to the most recent release starting with the incomplete
version number, e.g. `v4.10` is equivalent to `v4.10.2`. This will **not** expand to pre-releases, and again the leading `v` is
Expand Down
10 changes: 7 additions & 3 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ runs:
id: version
shell: bash
env:
OLDEST_VER: "4.9"
OLDEST_VER: "4.9.1"
run: |
VERSION=""
IS_RELEASE=true
Expand Down Expand Up @@ -124,9 +124,13 @@ runs:
# Remove leading stuff if present
PKG_VER=${PKG_VER##*[>= ]}

# Ensure the extracted version is not below the oldest GAP version supported by this GAP acttion
# Ensure the extracted version is not below the oldest GAP version supported by this GAP action

REL=$(printf '%s\n' "${PKG_VER}" "${OLDEST_VER}" | sort -V | tail -n1)
echo "Version: turned \"${PKG_VER}\" into \"${REL}\""
if [[ "${PKG_VER}" != "${REL}" ]]; then
echo "Version: ${PKG_VER} not supported by this action, using ${REL} instead"
fi

else
echo "::error::Could not extract minimal supported version from PackageInfo.g."
exit 1
Expand Down
Loading