Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 53.55% 53.75% +0.20%
==========================================
Files 34 34
Lines 17059 17066 +7
==========================================
+ Hits 9136 9174 +38
+ Misses 7923 7892 -31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The Buekenhout-Hermand criterion must hold for every set of types J
with |J| >= 3, but only the suffixes {k..n} were checked. For rank 4
this skipped {1,2,3}, {1,2,4} and {1,3,4}, so some coset incidence
systems with several orbits on flags were reported as flag-transitive.
Check all such J, with the minimal type of J as the distinguished one.
Fixes #57
Assisted-by: Claude Code (Opus 5.5)
fingolfin
force-pushed
the
mh/fix-flag-transitivity
branch
from
October 1, 2026 23:53
d3264da to
465300d
Compare
GAP does not document which point of FactorCosetAction corresponds to the subgroup itself. Build the action from an explicit transversal and look the trivial coset up instead. Also add a flag-transitive rank-4 case to the regression test, so a method that always answers false would fail it. Assisted-by: Claude Code (Fable 5.1)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Buekenhout-Hermand criterion must hold for every set of types J with |J| >= 3, but only the suffixes {k..n} were checked. For rank 4 this skipped {1,2,3}, {1,2,4} and {1,3,4}, so some coset incidence systems with several orbits on flags were reported as flag-transitive.
Check all such J, with the minimal type of J as the distinguished one.
Fixes #57
Assisted-by: Claude Code (Opus 5.5)