Skip to content

Give duplicate manual entries distinct labels - #60

Merged
fingolfin merged 1 commit into
masterfrom
mh/doc-duplicate-labels
Oct 1, 2026
Merged

fingolfin merged 1 commit into
masterfrom
mh/doc-duplicate-labels

Conversation

@fingolfin

Copy link
Copy Markdown
Member

GAPDoc derives each LaTeX label from the entry name plus its optional Label attribute, so 114 names documented more than once produced 309 "multiply defined" LaTeX warnings. Label all but one entry per name (keeping existing s pointing at the unlabelled one), drop literally duplicated entries, fix the ElementsOfIncidencStructure typo, and rename reused section labels.

Also fix the BibTeX warning for Tits1959, whose issue number is really the volume.

With the build now warning-free, re-enable warnings-as-errors in the docs workflow.

Fixes #45

Assisted-by: Claude Code (Opus 5.5)

GAPDoc derives each LaTeX label from the entry name plus its optional
Label attribute, so 114 names documented more than once produced 309
"multiply defined" LaTeX warnings. Label all but one entry per name
(keeping existing <Ref>s pointing at the unlabelled one), drop
literally duplicated entries, fix the ElementsOfIncidencStructure
typo, and rename reused section labels.

Also fix the BibTeX warning for Tits1959, whose issue number is really
the volume.

With the build now warning-free, re-enable warnings-as-errors in the
docs workflow.

Fixes #45

Assisted-by: Claude Code (Opus 5.5)
@fingolfin fingolfin added the documentation Improvements or additions to documentation label Oct 1, 2026
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.48%. Comparing base (07cb0c6) to head (ab2fedc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   53.48%   53.48%           
=======================================
  Files          34       34           
  Lines       17041    17041           
=======================================
  Hits         9115     9115           
  Misses       7926     7926           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin
fingolfin merged commit ef36856 into master Oct 1, 2026
6 checks passed
@fingolfin
fingolfin deleted the mh/doc-duplicate-labels branch October 1, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Labels multiply defined

1 participant