Repository navigation
Add dot correctness tsts - #127
Merged
james-d-mitchell merged 2 commits intoOct 16, 2026
Merged
james-d-mitchell merged 2 commits into
james-d-mitchell merged 2 commits into
Conversation
Parse generated DOT during the test suite and reject unexpected validation failures. AI assistance: Codex (GPT-6) separated the existing changes into commits. Assisted-by: Codex (GPT-6)
james-d-mitchell
force-pushed
the
add-dot-correctness-tsts
branch
from
October 16, 2026 11:42
6b82723 to
3c22c0a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 96.40% 95.95% -0.45%
==========================================
Files 12 13 +1
Lines 1167 1236 +69
==========================================
+ Hits 1125 1186 +61
- Misses 42 50 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It occurred to me at some point that although the package itself doesn't contain any validation (or much at least), when making changes to the package we'd like to make sure that we don't introduce changes that change the output strings, and make them invalid in the process (i.e. that we don't introduce changes that make previously valid DOT output now be invalid). This PR adds this to the test setup. It highlighted a couple of issues in the tests themselves. I resolved one of these, and indicated that the other (related to HTML labels) should be fixed when we fix the quoting of labels.
Produced with the assistance of Codex GPT6 (this description written by a human tho).