Skip to content

Make the Makefile self-documenting - #80

Merged
fingolfin merged 1 commit into
masterfrom
mh-claude/Makefile
Oct 1, 2026
Merged

fingolfin merged 1 commit into
masterfrom
mh-claude/Makefile

Conversation

@fingolfin

Copy link
Copy Markdown
Member

Running make or make help now lists the targets, taken from their ## description comments, and explains how to pick a GAP executable.

Also:

  • resolve paths relative to the Makefile, so make -f works from any directory
  • quote the package directory, so paths with spaces work
  • spell out the patterns in clean, which relied on bash brace expansion and deleted nothing under a POSIX /bin/sh such as dash
  • add test as an alias for check

Assisted-by: Claude Code (Opus 5.5)

Running `make` or `make help` now lists the targets, taken from their
`## description` comments, and explains how to pick a GAP executable.

Also:
- resolve paths relative to the Makefile, so `make -f` works from
  any directory
- quote the package directory, so paths with spaces work
- spell out the patterns in `clean`, which relied on bash brace
  expansion and deleted nothing under a POSIX /bin/sh such as dash
- add `test` as an alias for `check`

Assisted-by: Claude Code (Opus 5.5)
@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.29%. Comparing base (6f8f7d4) to head (038a97a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   67.29%   67.29%           
=======================================
  Files           9        9           
  Lines        1006     1006           
=======================================
  Hits          677      677           
  Misses        329      329           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin
fingolfin requested a review from mtorpey September 28, 2026 13:36
@fingolfin
fingolfin merged commit 215733d into master Oct 1, 2026
6 checks passed
@fingolfin
fingolfin deleted the mh-claude/Makefile branch October 1, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant