Repository navigation
AddToIgs improvements 3: skip the adjust step when it is not needed - #237
Merged
Merged
Conversation
Skip adjustment in AddToIgs if there is no need for it Assisted-by: Claude Code (Opus 5.5, Fable 5.1)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 69.45% 69.50% +0.04%
==========================================
Files 88 88
Lines 12829 12849 +20
==========================================
+ Hits 8911 8931 +20
Misses 3918 3918
🚀 New features to boost your workflow:
|
fingolfin
reviewed
Oct 16, 2026
Co-authored-by: Max Horn <max@quendi.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #174. That PR does a lot of (sometimes independent) changes, my hope is that it's easier to get that reviewed by splitting it in smaller chunks.
This PR does not depend on #235 or #236, though again it will have small merge conflicts in the declaration of local vars.
One notable difference with #174:
addedis originally defined astruehere, instead offalse. That's because #174 uses separate variables to store the original generators and the added powers and commutators, sotodostarts empty there and hence nothing was added yet, whereas in this PR the original generators have been "added".Original PR disclaimer:
Assisted-by: Claude Code (Opus 5.5, Fable 5.1)