Skip to content

AddToIgs improvements 3: skip the adjust step when it is not needed - #237

Merged
fingolfin merged 3 commits into
gap-packages:masterfrom
stertooy:igs-improv-3
Oct 17, 2026
Merged

fingolfin merged 3 commits into
gap-packages:masterfrom
stertooy:igs-improv-3

Conversation

@stertooy

Copy link
Copy Markdown
Collaborator

Extracted from #174. That PR does a lot of (sometimes independent) changes, my hope is that it's easier to get that reviewed by splitting it in smaller chunks.

This PR does not depend on #235 or #236, though again it will have small merge conflicts in the declaration of local vars.

One notable difference with #174: added is originally defined as true here, instead of false. That's because #174 uses separate variables to store the original generators and the added powers and commutators, so todo starts empty there and hence nothing was added yet, whereas in this PR the original generators have been "added".

Original PR disclaimer:
Assisted-by: Claude Code (Opus 5.5, Fable 5.1)

Skip adjustment in AddToIgs if there is no need for it

Assisted-by: Claude Code (Opus 5.5, Fable 5.1)
@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.50%. Comparing base (8ac6b81) to head (c2b56c9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   69.45%   69.50%   +0.04%     
==========================================
  Files          88       88              
  Lines       12829    12849      +20     
==========================================
+ Hits         8911     8931      +20     
  Misses       3918     3918              
Files with missing lines Coverage Δ
gap/basic/pcppara.gi 92.92% <100.00%> (+0.24%) ⬆️
gap/basic/pcppcps.gi 83.42% <100.00%> (+0.39%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stertooy stertooy changed the title Small optimisations for AddToIgs code (3) AddToIgs improvements 3: skip the adjust step when it is not needed Oct 12, 2026
Comment thread gap/basic/pcppcps.gi Outdated
Comment thread gap/basic/pcppara.gi Outdated
@fingolfin
fingolfin merged commit 3616967 into gap-packages:master Oct 17, 2026
5 checks passed
@stertooy
stertooy deleted the igs-improv-3 branch October 21, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants