[stertooy]

Extracted from #174, builds upon #235. I'll mark this a draft PR until that one is merged and this has been rebased.

This only really does one thing, which is ensuring IGSValFun is not recalculated when we already know its value.

Original PR disclaimer:
Assisted-by: Claude Code (Opus 5.5, Fable 5.1)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.64%. Comparing base (b4845dc) to head (f25e0a2).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   69.58%   69.64%   +0.05%     
==========================================
  Files          88       88              
  Lines       12875    12899      +24     
==========================================
+ Hits         8959     8983      +24     
  Misses       3916     3916              

Files with missing lines	Coverage Δ
gap/basic/pcppara.gi	93.27% <100.00%> (+0.34%)	⬆️
gap/basic/pcppcps.gi	83.80% <100.00%> (+0.37%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fingolfin]

This PR is marked as "draft" so I am not merging it.

Something else: perhaps one of these PRs should add a comment to CHANGES.md that indicates a speed up in Igs computation? Plus fixes...

[stertooy]

I'll mark this as ready once I get it rebased :)

Something else: perhaps one of these PRs should add a comment to CHANGES.md that indicates a speed up in Igs computation? Plus fixes...

Yes, currently we list AddToIgs (and variants) in the big list of fixed functions. And originally it often a bit slower than the old implementation. But I'm quite confident that with all these improvements it will be faster overall, and in many cases much faster. So with that, and given the importance of calculating igs'es, it probably deserves its own separate entry in the changelog, somewhere near the top.

[stertooy]

Rebased and ready for review :)