Skip to content

Fix invalid Cgs input in AddToIgs test - #240

Merged
stertooy merged 1 commit into
gap-packages:masterfrom
stertooy:fix-test
Oct 15, 2026
Merged

stertooy merged 1 commit into
gap-packages:masterfrom
stertooy:fix-test

Conversation

@stertooy

Copy link
Copy Markdown
Collaborator

I noticed that #174 included a change to .tst file, where the output of a test was changed. That seemed really fishy, but it turns out the problem is due to #159 (i.e. my own damn fault).

Previously, this test did Igs( gen ), where gen is a generating set. When I changed the tests to use Cgs instead of Igs, I changed that to Cgs( gen ), but that use case isn't supported. When giving Cgs a list as input, it assumes said list is an igs, which isn't the case here, so the output is again unreliable. This PR fixes that.

@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.81%. Comparing base (109f23a) to head (0f7f80c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #240   +/-   ##
=======================================
  Coverage   67.81%   67.81%           
=======================================
  Files          88       88           
  Lines       12916    12916           
=======================================
  Hits         8759     8759           
  Misses       4157     4157           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stertooy
stertooy merged commit b848b67 into gap-packages:master Oct 15, 2026
5 checks passed
@stertooy
stertooy deleted the fix-test branch October 21, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant