Repository navigation
Fix invalid Cgs input in AddToIgs test - #240
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #240 +/- ##
=======================================
Coverage 67.81% 67.81%
=======================================
Files 88 88
Lines 12916 12916
=======================================
Hits 8759 8759
Misses 4157 4157 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that #174 included a change to
.tstfile, where the output of a test was changed. That seemed really fishy, but it turns out the problem is due to #159 (i.e. my own damn fault).Previously, this test did
Igs( gen ), wheregenis a generating set. When I changed the tests to useCgsinstead ofIgs, I changed that toCgs( gen ), but that use case isn't supported. When givingCgsa list as input, it assumes said list is an igs, which isn't the case here, so the output is again unreliable. This PR fixes that.