Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 69.45% 74.00% +4.54%
==========================================
Files 88 88
Lines 12829 14353 +1524
==========================================
+ Hits 8911 10622 +1711
+ Misses 3918 3731 -187
🚀 New features to boost your workflow:
|
fingolfin
reviewed
Oct 17, 2026
| # compute snf if needed | ||
| if not IsSNFPcp( pcp ) and | ||
| Length( Set( RelativeOrdersOfPcp( pcp ) ) ) > 1 then | ||
| pcp := Pcp( GroupOfPcp( pcp ), |
Member
There was a problem hiding this comment.
This replaces the caller's pcp, so A.normal and the cocycle coordinates refer to a different basis than the input. doc/cohom.xml describes normal as either Pcp(A) or the input pcp. So shouldn't we update it to mention the SNF replacement for mixed relative orders?
Collaborator
Author
There was a problem hiding this comment.
I guess so. I'm starting to wonder now whether we should document this, or instead throw an error...
Collaborator
Author
|
Accidentally deleted this earlier... But I'll mark this as a draft, since I'm still unsure what the best course of action is. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #260.
Recomputes the pcp, but in snf, if necessary.
AI Disclosure: bug discovered by GPT-6 Astra during a package audit.