Repository navigation
AddToIgs improvements 6: cache small negative powers - #277
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 71.51% 71.61% +0.10%
==========================================
Files 88 88
Lines 13029 13076 +47
==========================================
+ Hits 9318 9365 +47
Misses 3711 3711
🚀 New features to boost your workflow:
|
stertooy
force-pushed
the
igs-improv-6
branch
from
October 20, 2026 09:40
8328e76 to
695669d
Compare
stertooy
force-pushed
the
igs-improv-6
branch
from
October 22, 2026 11:27
62e52fc to
80b43bc
Compare
stertooy
marked this pull request as draft
October 22, 2026 11:35
stertooy
marked this pull request as ready for review
October 22, 2026 15:24
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #174.
This caches small negative powers of elements of the currently computed igs.
I added some (small?) improvement of my own:
ind[d]^-q, this only tried to either get this exact value from the cache, or getind[d]^-1from the cache and then compute(ind[d]^-1)^q. I made it so this also tries to find someind[d]^-sfrom the cache and then compute(ind[d]^-s)^(q/s)(where of coursesdividesq).Unbindinstead of setting things to[].Original PR disclaimer:
Assisted-by: Claude Code (Fable 5.1)