Skip to content

Classical natural tests#200

Closed
ssiccha wants to merge 5 commits into
gap-packages:masterfrom
ssiccha:ss/misc-3
Closed

Classical natural tests#200
ssiccha wants to merge 5 commits into
gap-packages:masterfrom
ssiccha:ss/misc-3

Conversation

@ssiccha

@ssiccha ssiccha commented Oct 31, 2020

Copy link
Copy Markdown
Collaborator

No description provided.

@ssiccha ssiccha added the tests label Oct 31, 2020
@ssiccha ssiccha self-assigned this Oct 31, 2020
@ssiccha ssiccha requested a review from fingolfin October 31, 2020 08:19
@codecov

codecov Bot commented Oct 31, 2020

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.44%. Comparing base (9bd5043) to head (d460267).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   88.44%   88.44%           
=======================================
  Files          45       45           
  Lines       19008    19008           
=======================================
  Hits        16812    16812           
  Misses       2196     2196           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tst/working/quick/sl3.tst
@ssiccha

ssiccha commented Nov 6, 2020

Copy link
Copy Markdown
Collaborator Author

Unfortunately on my machine, some of the smaller GLs fail. relatively regularly. I'll try to find out which ones that are. I have seen that there already are related issues, so I'll look there too.

@fingolfin fingolfin closed this Nov 16, 2020
@fingolfin fingolfin reopened this Nov 16, 2020
@ssiccha ssiccha changed the title Clean up tests Classical natural tests Nov 25, 2020
@fingolfin

Copy link
Copy Markdown
Member

We now have tst/working/quick/ClassicalNaturalNaming.tst. Might be better to extend that instead. Perhaps also get rid of tst/testclassicalnatural.g; for that, we maybe should...

  • make the number of repetitions in TestNaming an argument??
  • teach TestNaming to use randomize generating sets (but really, even without that we already find plenty bugs)
  • add more input tests; inspired by tst/testclassicalnatural.g and this PR?

That test is already covered by working/veryslow/ClassicalNatural.tst
@SoongNoonien SoongNoonien requested a review from fingolfin March 31, 2026 09:20
@fingolfin

Copy link
Copy Markdown
Member

Removing sl3.tst seems sensible.

But I would not bother moving individual tests from veryslow to quick these days. If we want to have some of those tests run in "quick" mode, I'd suggest we instead move the test to tst/combined and use #@if comments to run parts only in (very)slow mode

@fingolfin

Copy link
Copy Markdown
Member

With only the sl3.tst removal left, this is not so useful.

I am still interested in moving tst/working/veryslow/ClassicalNatural.tst to tst/working/combined (and adapting it suitably) but that can be done in a new PR.

@fingolfin fingolfin closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants