add RECOG.FindSL2inSL4: Find SL(2,q) as stingray subgroup of SL(4,q)#504
Open
Till-Eisen wants to merge 5 commits into
Open
add RECOG.FindSL2inSL4: Find SL(2,q) as stingray subgroup of SL(4,q)#504Till-Eisen wants to merge 5 commits into
Till-Eisen wants to merge 5 commits into
Conversation
28ce299 to
e99f50b
Compare
fingolfin
reviewed
Jun 23, 2026
cd17bbb to
08490d3
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #504 +/- ##
==========================================
+ Coverage 88.46% 88.67% +0.21%
==========================================
Files 45 46 +1
Lines 19019 19070 +51
==========================================
+ Hits 16825 16911 +86
+ Misses 2194 2159 -35
🚀 New features to boost your workflow:
|
fingolfin
reviewed
Jun 23, 2026
fingolfin
reviewed
Jun 23, 2026
8a5db87 to
1a74d97
Compare
fingolfin
reviewed
Jun 30, 2026
| ReadPackage("recog","gap/projective/almostsimple/hints.gi"); | ||
| ReadPackage("recog","gap/projective/classicalnatural.gi"); | ||
| ReadPackage("recog","gap/projective/sl2_natural.gi"); | ||
| ReadPackage("recog","gap/projective/sl4_natural.gi"); |
Member
There was a problem hiding this comment.
Good, now that your functions gets loaded, have you tried actually using it, i.e., by modifying RECOG.SLn_constructsl2 to call you code, instead?
feb8a8f to
0bb40a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
gap/projective/SL4_natural.gi, which implementsRECOG.FindSL2inSL4(G, N).Given G = SL(4,q) (q odd), the function finds a subgroup U isomorphic to SL(2,q) stingray-embedded in G: concretely, a base change matrix
basis computed such that every element of U is block-diagonal diag(A, I_2) in the new basis.