Skip to content

add RECOG.FindSL2inSL4: Find SL(2,q) as stingray subgroup of SL(4,q)#504

Open
Till-Eisen wants to merge 5 commits into
gap-packages:masterfrom
Till-Eisen:FindSL2inSL4
Open

add RECOG.FindSL2inSL4: Find SL(2,q) as stingray subgroup of SL(4,q)#504
Till-Eisen wants to merge 5 commits into
gap-packages:masterfrom
Till-Eisen:FindSL2inSL4

Conversation

@Till-Eisen

Copy link
Copy Markdown
Collaborator

This PR adds gap/projective/SL4_natural.gi, which implements RECOG.FindSL2inSL4(G, N).

Given G = SL(4,q) (q odd), the function finds a subgroup U isomorphic to SL(2,q) stingray-embedded in G: concretely, a base change matrix bas is computed such that every element of U is block-diagonal diag(A, I_2) in the new basis.

@Till-Eisen Till-Eisen force-pushed the FindSL2inSL4 branch 3 times, most recently from 28ce299 to e99f50b Compare June 23, 2026 09:50
@Till-Eisen Till-Eisen added the sl_n issue related to sl_n detection (may be resolved by new SL_n code) label Jun 23, 2026
@Till-Eisen Till-Eisen linked an issue Jun 23, 2026 that may be closed by this pull request
Comment thread gap/projective/sl4_natural.gi
@Till-Eisen Till-Eisen force-pushed the FindSL2inSL4 branch 2 times, most recently from cd17bbb to 08490d3 Compare June 23, 2026 11:16
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.67%. Comparing base (858e2e7) to head (ec5a52c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
gap/projective/sl4_natural.gi 90.19% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   88.46%   88.67%   +0.21%     
==========================================
  Files          45       46       +1     
  Lines       19019    19070      +51     
==========================================
+ Hits        16825    16911      +86     
+ Misses       2194     2159      -35     
Files with missing lines Coverage Δ
gap/projective/sl4_natural.gi 90.19% <90.19%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread gap/projective/SL4_natural.gi Outdated
Comment thread gap/projective/sl4_natural.gi Outdated
Comment thread tst/working/quick/sl4.tst Outdated
Comment thread gap/projective/sl4_natural.gi Outdated
Comment thread gap/projective/sl4_natural.gi Outdated
@Till-Eisen Till-Eisen force-pushed the FindSL2inSL4 branch 4 times, most recently from 8a5db87 to 1a74d97 Compare June 30, 2026 07:37
@Till-Eisen Till-Eisen changed the title Add FindSL2inSL4: Find SL(2,q) as stingray subgroup of SL(4,q) add RECOG.FindSL2inSL4: Find SL(2,q) as stingray subgroup of SL(4,q) Jun 30, 2026
@Till-Eisen Till-Eisen added the topic: classical groups related to recognition of classical groups label Jun 30, 2026
Comment thread gap/projective/sl4_natural.gi Outdated
Comment thread gap/projective/sl4_natural.gi Outdated
Comment thread gap/projective/sl4_natural.gi Outdated
Comment thread gap/projective/sl4_natural.gi Outdated
Comment thread gap/projective/sl4_natural.gi Outdated
Comment thread gap/projective/sl4_natural.gi Outdated
Comment thread gap/projective/sl4_natural.gi Outdated
Comment thread gap/projective/sl4_natural.gi Outdated
Comment thread gap/projective/sl4_natural.gi Outdated
Comment thread read.g
ReadPackage("recog","gap/projective/almostsimple/hints.gi");
ReadPackage("recog","gap/projective/classicalnatural.gi");
ReadPackage("recog","gap/projective/sl2_natural.gi");
ReadPackage("recog","gap/projective/sl4_natural.gi");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, now that your functions gets loaded, have you tried actually using it, i.e., by modifying RECOG.SLn_constructsl2 to call you code, instead?

@Till-Eisen Till-Eisen force-pushed the FindSL2inSL4 branch 2 times, most recently from feb8a8f to 0bb40a3 Compare July 7, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sl_n issue related to sl_n detection (may be resolved by new SL_n code) topic: classical groups related to recognition of classical groups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add better code for finding SL(2,q) inside SL(4,q)

2 participants