Skip to content

[cctab] New package, version 0.4 - #1578

Open
gap-package-distribution-bot[bot] wants to merge 1 commit into
mainfrom
automatic/cctab
Open

[cctab] New package, version 0.4#1578
gap-package-distribution-bot[bot] wants to merge 1 commit into
mainfrom
automatic/cctab

Conversation

@gap-package-distribution-bot

@gap-package-distribution-bot gap-package-distribution-bot Bot commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Auto-merge

This pull request may be auto-merged after all required checks pass.
To prevent this pull request from being auto-merged, leave a comment.
To comment without blocking auto-merge, include [noblock] in the comment.

@gap-package-distribution-bot gap-package-distribution-bot Bot added automated pr Automatically applied to PRs created by a GH workflow new package labels Sep 30, 2026
@fingolfin

fingolfin commented Oct 1, 2026

Copy link
Copy Markdown
Member

@frankluebeck fails on import due to an invalid README_URL:

cctab: FAILED: 404 Client Error: Not found for url: https://www.math.rwth-aachen.de/~Frank.Luebeck/gap/CCTab/README.md

Just putting that file on the server in that spot should be enough, we can then restart the job here.

@frankluebeck

frankluebeck commented Oct 1, 2026

Copy link
Copy Markdown
Member

Thanks, I was not aware that the README is used by the package distribution. I have adjusted the webpage such that it should work now.

@fingolfin fingolfin closed this Oct 1, 2026
@fingolfin fingolfin reopened this Oct 1, 2026
@fingolfin

fingolfin commented Oct 1, 2026

Copy link
Copy Markdown
Member

@frankluebeck we do not really use the README_URL, but it is a required part of PackageInfo.g, so the validator does check it.

I'd be happy to reconsider this and switch README_URL to optional and stop using it on the website but that's something to be discussed elsewhere.

@gap-package-distribution-bot

gap-package-distribution-bot Bot commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Package Evaluation Report for GAP master

Job Properties

Testing: master/2026/10/08_22-21-38 vs master/2026/10/08_22-19-16

Distribution revision: fa9e6a72

Generated by Workflow: https://github.com/gap-system/PackageDistro/actions/runs/37849861375

In total, 174 packages were tested, out of which 170 succeeded, 1 failed and 3 were skipped.

New Packages

❗ Packages still failing

1 package(s) failed tests also on the previous version.

✔️ Packages still succeeding

169 package(s) succeeded tests also on the previous version.

Click to show packages!

➖ Packages that were skipped

3 package(s) skipped tests also on the previous version.

Click to show packages!

@fingolfin

fingolfin commented Oct 6, 2026

Copy link
Copy Markdown
Member

@frankluebeck @ThomasBreuer the GAP test suite fails after LoadAllPackages(), which now included CCTab (but also, for now, InduceReduce); is that expected?

testing: ~/gap/tst/testinstall/ctbl.tst
########> Diff in ~/gap/tst/testinstall/ctbl.tst:367
# Input is:
ClassPositionsOfLowerCentralSeries( t );
# Expected output:
[ [ 1 .. 12 ], [ 1, 3, 4, 5, 6, 9, 10, 11 ] ]
# But found:
[ [ 1 .. 12 ], [ 1, 2, 3, 4, 7, 8, 9, 10 ] ]
########
########> Diff in ~/gap/tst/testinstall/ctbl.tst:379
# Input is:
ClassPositionsOfSupersolvableResiduum( t );
# Expected output:
[ 1, 5, 6 ]
# But found:
[ 1, 3, 6 ]
########

and

testing: ~/gap/tst/testinstall/ctblmono.tst
########> Diff in ~/gap/tst/testinstall/ctblmono.tst:29
# Input is:
chi:= irr[7];
# Expected output:
Character( CharacterTable( SL(2,3) ), [ 3, 0, 0, 3, 0, 0, -1 ] )
# But found:
Character( CharacterTable( SL(2,3) ), [ 3, 3, 0, 0, -1, 0, 0 ] )
########
########> Diff in ~/gap/tst/testinstall/ctblmono.tst:37
# Input is:
chi:= irr[4];
# Expected output:
Character( CharacterTable( SL(2,3) ), [ 2, 1, 1, -2, -1, -1, 0 ] )
# But found:
Character( CharacterTable( SL(2,3) ), [ 2, -2, -1, -1, 0, 1, 1 ] )
########
########> Diff in ~/gap/tst/testinstall/ctblmono.tst:39
# Input is:
cln:= ClassPositionsOfNormalSubgroup( CharacterTable( Sl23 ), n );
# Expected output:
[ 1, 4, 7 ]
# But found:
[ 1, 2, 5 ]
########

@ThomasBreuer

ThomasBreuer commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

is that expected?

I have to open a pull request for making some output more robust (i.e., independent of the order of columns and rows of character tables).
There are more differences in files in tst/teststandard.

@ThomasBreuer ThomasBreuer mentioned this pull request Oct 6, 2026
Merged
@fingolfin

fingolfin commented Oct 7, 2026

Copy link
Copy Markdown
Member

Now proceeds further, but:

Syntax warning: Unbound global variable in /home/runner/gap/pkg/CCTab-0.3/lib/\
PositionConjugacyClass.gi:160
      return FrobeniusNormalForm(x)[1];
             ^^^^^^^^^^^^^^^^^^^

@ThomasBreuer

ThomasBreuer commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

The syntax warning about FrobeniusNormalForm is harmless, the function will be called only if the nofoma package is loaded.

@fingolfin

fingolfin commented Oct 7, 2026

Copy link
Copy Markdown
Member

While it is harmless, it also is scary for users. And it can be avoided

I am not sure if it is already on the list, but in practice we so far rejected packages with syntax warnings

@fingolfin

fingolfin commented Oct 7, 2026

Copy link
Copy Markdown
Member

Anyway, the segfaults when trying to run the test suite are a bigger problem.

@fingolfin

fingolfin commented Oct 8, 2026

Copy link
Copy Markdown
Member

Posted frankluebeck/CCTab#6 and frankluebeck/CCTab#7

@gap-package-distribution-bot gap-package-distribution-bot Bot changed the title [cctab] New package, version 0.3 [cctab] New package, version 0.4 Oct 8, 2026
@frankluebeck

frankluebeck commented Oct 9, 2026

Copy link
Copy Markdown
Member

As far as I can see, all points above are resolved with the new release 0.4.
Is there anything else I should do?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated pr Automatically applied to PRs created by a GH workflow new package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fingolfin @frankluebeck @ThomasBreuer