Repository navigation
Conversation
fingolfin
added
kind: bug
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6776 +/- ##
=======================================
Coverage 79.68% 79.68%
=======================================
Files 684 684
Lines 295461 295472 +11
Branches 8656 8657 +1
=======================================
+ Hits 235427 235439 +12
+ Misses 58206 58205 -1
Partials 1828 1828 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spawnve cannot set the child's working directory, so the Cygwin variant of SyExecuteProcess changes GAP's own, and never back: every `Process` or `RunProcess` call with a directory leaves GAP there. Change the directory only around spawnve and restore it afterwards, keeping errno from chdir or spawnve for the caller. Doing both after the descriptor setup leaves no early return between them. Assisted-by: Generative AI
fingolfin
force-pushed
the
mh-claude/cygwin-process-cwd
branch
from
October 19, 2026 11:08
ec0f580 to
29d7f04
Compare
ChrisJefferson
approved these changes
Oct 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spawnvecannot set the child's working directory, so the Cygwin variant ofSyExecuteProcesschanges GAP's own, and never back: everyProcessorRunProcesscall with a directory leaves GAP there.Change the directory only around spawnve and restore it afterwards, keeping
errnofromchdirorspawnvefor the caller. Doing both after the descriptor setup leaves no early return between them.Assisted-by: Generative AI