Conversation
…the threshold but that country has no loss at all (do not generate the corresponding report)
…xporting to csv and reading from the exported file
… readable from it
…emap to avoid redundancy
…ded by the risk team with different column names
…use them directly in the pdf
…ect of the impact report to make
…ponding label to the legends
…nt; refine the styling of some markers and labels
… as countries_info_file
…ps. Refine markers and fonts
…n cities to display
…shold on population
…de in the plots the top cities in the viewport belonging to the reporting country
… describing invalid geometries (only once)
…o for all loss types
…r the random name of the temporary internal copy of the rupture file
… outputs (grouping all outputs together instead)
…roach using the finite-fault model from the USGS
…ete before subsequent interactions (like clicking download buttons or remove actions)
…guity among possible multiple matches
…sing rupture model
… damage' -> 'Affected population'
…he hardcoded value of 300km
…values exeed the last bound
…ror report-generation logs in server and job logs
…en if all other loss values are below the negligible-loss threshold
…ions also for exposed value, mean and quantiles
…'No uncertainty' checkbox
Member
Author
|
Replaced by #11784 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch has been there for months and it's time to finalize it.
Now we are busy with other urgent tasks, but I am opening this PR as a draft, so we can start reviewing the code.
The new feature require some additional python packages and I decided to create a separate requirements file specific for impact (and I did the same for aelo).
I finally managed to fix also the UI tests:
https://github.com/gem/oq-engine/actions/runs/32850716659
They had a very strange behavior, working smoothly in headed mode (showing the process in a browser window) but failing in headless mode.
We should double-check that all the files we are using to generate the reports are updated and "usable" (in terms of licenses, etc.).