Bump claude-commander to v0.21.0 + review/PR parity features#27
Merged
Conversation
Update the pinned claude-commander dependency from v0.17.0 to v0.20.0 and
wire up the new required telemetry frontend identity, plus three TUI parity
features for the GUI.
- Bump tag + Cargo.lock; pass `FrontendInfo::new("cc-gui", VERSION)` to
`for_cli` (now mandatory). Telemetry is accepted on by default and
identifies as `cc-gui` so it's distinguishable from the terminal app.
- Settings pane: surface `telemetry.enabled` as a friendly opt-out checkbox
(preserving endpoint/token) instead of a raw JSON blob; document telemetry
+ opt-out in the README.
- Review keyboard nav (#156): up/down and Ctrl-P/Ctrl-N move between files.
- Refresh PR status (#154): debounced backend command + palette entry.
- Reviewed files (#160): clickable o/check toggle per row (persisted via
toggle_file_reviewed, shared with the TUI) bands reviewed rows.
- Update help overlay + README keyboard table; extend the Tauri simulator
and add iwft coverage for the reviewed toggle, file nav, and the
telemetry opt-out.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
A clean tag-only bump with no GUI code change. v0.21.0 is library-internal fixes the GUI inherits for free, with no public API churn: - Review diff resolves against the live base branch, not a frozen SHA (#166), plus base_branch backfill on runtime state reads (#167). - Deleting a mid-stack session now retargets its stacked children (#168/#169); the GUI's `svc.delete_session` call is unchanged and picks this up. - Telemetry enablement/ingest is now observable from the log (#165). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Extended this PR to bump straight through to v0.21.0 (was v0.20.0). v0.21.0 is a clean tag-only bump with no GUI code change — all library-internal fixes inherited for free, no public API churn:
Gates re-run green on v0.21.0: |
Ed-Barnes937
changed the title
claude-commander v0.20+ pulls in ALSA (via rodio/cpal for TTS audio) on Linux, so the clippy job and the Linux release bundle now need the ALSA dev headers to compile alsa-sys. macOS uses CoreAudio and is unaffected. Add libasound2-dev to the apt installs in both the clippy CI job and the Linux release job. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Homebrew cask is updated by hand for now, so guard the update-cask job off to avoid it racing the manual tap push. Reversible — drop the `if: false` to restore automatic tap updates on release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the pinned
claude-commanderdependency from v0.17.0 → v0.20.0 and adopts the new features that matter to the GUI. Audit-driven: the only forced code change from the bump was the new mandatory telemetry frontend identity; the rest are deliberate parity additions.Dependency bump
Cargo.tomltag →v0.20.0,Cargo.lockupdated (pulls in CC's new TTS/telemetry transitive deps).service.rspassesFrontendInfo::new("cc-gui", env!("CARGO_PKG_VERSION"))tofor_cli(now required). Inherits CC's review-diff base fixes (#161/#162) for free.Telemetry (accepted, on by default)
CC v0.20 adds anonymous feature-usage telemetry, on by default. We accept it; it identifies as
cc-guiso GUI usage is distinguishable from the terminal app byfrontend_name.telemetry.enablednow renders as a friendly opt-out checkbox (preserving endpoint/token) instead of a raw JSON blob.DO_NOT_TRACK).Parity features
↑/↓andCtrl-P/Ctrl-Nmove between files in the review view (it had none before).refresh_pr_statusbackend command + palette entry; sidebar reflects it on its next poll tick.○/✓per file row toggles reviewed (persisted viatoggle_file_reviewed, shared with the TUI) and bands reviewed rows.Not included (per discussion): conversation/voice mode, and the delete-dialog naming (the GUI has its own click-twice-to-delete).
Docs & tests
?help overlay and the README keyboard table.reviewedfield) and added iwft coverage for the reviewed toggle, file navigation, and the telemetry opt-out.Verification
cargo check·clippy·fmt --check·cargo test·npm run typecheck·npm test(49) ·npm run test-iwft(63) ·npm run build— all green.🤖 Generated with Claude Code