fix: resolve confirmed v2-dev bug-hunt findings - #201
Open
MuncleUscles wants to merge 2 commits into
Open
Conversation
Adds tests/bug-hunt-v2dev.test.ts: 12 tests, each reproducing a distinct
confirmed defect on the v2-dev (v0.6) integration branch. Every test is
expected to FAIL against current code and should pass once the underlying
bug is fixed. File:line and root cause are documented inline per block.
Wrong results:
- calldata toString(): map entries emitted with no separator ({"a":1"b":2})
- calldata toString(): per-byte hex not zero-padded (distinct bytes collide)
- toJsonSafeDeep(): shared (non-cyclic) references replaced with null
- createClient({endpoint}): mutates the shared chain-config singleton
- schema strictTypes: non-object accepted for struct param; float/NaN for int
- staking getValidatorInfo(): toHex() double-encodes already-hex extraCid
- vesting encodeExtraCid(): odd-length hex silently corrupted (0x123 -> 0x1230)
- isSuccessful(): always false for finalized studio/localnet transactions
Instability:
- calldata decode(): trusts attacker-supplied array/map counts (unbounded work)
- vesting exit: BigInt("") coerces empty shares to 0n and broadcasts
- staking: advertised isValidatorBelowMinStake helper missing at runtime
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017Xrmnk8SQeW3Aju4M7QHut
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MuncleUscles
changed the title
Member
Author
|
/run-e2e default v0.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds regression coverage and fixes the 12 confirmed defects found in the v2-dev bug hunt.
The fixes cover:
Validation
npm exec vitest run tests/bug-hunt-v2dev.test.ts— 12 passednpm exec vitest run -- --typecheck— 127 passed, no type errorsgit diff --checkThe existing RLP-decoding stderr in
transactions.test.tsremains benign and is covered by passing assertions.