Skip to content

fix: preserve serialized receipt errors in usage metrics - #1713

Merged
MuncleUscles merged 2 commits into
v0.123-devfrom
fable/bug-hunt-v0.123-dev
Jul 26, 2026
Merged

fix: preserve serialized receipt errors in usage metrics#1713
MuncleUscles merged 2 commits into
v0.123-devfrom
fable/bug-hunt-v0.123-dev

Conversation

@MuncleUscles

@MuncleUscles MuncleUscles commented Jul 26, 2026

Copy link
Copy Markdown
Member

What

Fixes a confirmed v0.123-dev usage-metrics defect and retains its regression coverage.

Serialized dictionary leader receipts were read with attribute access, causing ERROR execution results to fall through to the default success classification. The extractor now uses the existing dict/object-safe receipt helper.

This finding is separate from the catalog in #1704.

Validation

  • Usage-metrics and regression tests: 12 passed
  • Black check: passed

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 09d214ce-93ed-4759-a17c-9f19c754cee7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fable/bug-hunt-v0.123-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MuncleUscles MuncleUscles changed the title test: reproduce v0.123-dev usage-metrics receipt bug fix: preserve serialized receipt errors in usage metrics Jul 26, 2026
@MuncleUscles

Copy link
Copy Markdown
Member Author

/run-e2e default v0.6

@MuncleUscles
MuncleUscles marked this pull request as ready for review July 26, 2026 14:28
@MuncleUscles
MuncleUscles merged commit 2297c1a into v0.123-dev Jul 26, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant