Skip to content

fix: preserve exact faucet amounts in wei - #1714

Merged
MuncleUscles merged 1 commit into
v0.123-devfrom
agent/fix-faucet-amount-precision
Jul 26, 2026
Merged

fix: preserve exact faucet amounts in wei#1714
MuncleUscles merged 1 commit into
v0.123-devfrom
agent/fix-faucet-amount-precision

Conversation

@MuncleUscles

Copy link
Copy Markdown
Member

Summary

  • parse GEN decimal input directly to bigint without floating-point conversion
  • send exact decimal wei strings over JSON-RPC
  • reject unsupported precision and scientific notation

Verification

  • focused Vitest suite (2 passed)
  • Vue TypeScript check
  • pre-commit ESLint and Prettier hooks

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 80ea18e5-7db9-4895-8729-0500f595bda4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/fix-faucet-amount-precision

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MuncleUscles
MuncleUscles merged commit 4fca293 into v0.123-dev Jul 26, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant