Skip to content

Prevent post-install update entity flicker to “upgradable” #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Prevent post-install update entity flicker to “upgradable” #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55c6687
Initial plan
Copilot Jul 18, 2026
e8c48c8
fix: keep update entity in progress until refresh completes
Copilot Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tests/unit_tests/test_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,21 @@ async def test_install_requests_coordinator_refresh(self):

coordinator.async_request_refresh.assert_awaited_once()

async def test_install_keeps_in_progress_true_while_refresh_runs(self):
"""in_progress should remain True until coordinator refresh completes."""
entity, coordinator = _make_update_entity()
coordinator.create = AsyncMock()

async def _refresh_side_effect():
self.assertTrue(entity._attr_in_progress)

coordinator.async_request_refresh = AsyncMock(side_effect=_refresh_side_effect)

await entity.async_install(None, False)

coordinator.async_request_refresh.assert_awaited_once()
self.assertFalse(entity._attr_in_progress)

async def test_install_raises_when_coordinator_create_fails(self):
"""async_install should propagate ServiceValidationError from coordinator.create()."""
entity, coordinator = _make_update_entity()
Expand Down
8 changes: 5 additions & 3 deletions update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ async def async_install(
try:
await self.coordinator.create()
finally:

@gensyn gensyn Jul 18, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Is an empty finally block in python valid and reasonable?

Copilot AI Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes—try ... finally without an except is valid Python, and it’s commonly used for guaranteed cleanup. In this case the outer finally is not empty; it ensures we always run the post-install refresh/cleanup path even if create() raises.

self._attr_in_progress = False
self.async_write_ha_state()
# Refresh coordinator so the new container state is reflected quickly.
await self.coordinator.async_request_refresh()
try:
await self.coordinator.async_request_refresh()
finally:
self._attr_in_progress = False
self.async_write_ha_state()