Skip to content

Fix coordinate order for setBounds in LocationIQ.php #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zero0cool0 wants to merge 3 commits into
base: master
Choose a base branch
from
+36 −1
Open

Fix coordinate order for setBounds in LocationIQ.php #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6cd043
Fix coordinate order for setBounds in LocationIQ.php
zero0cool0 Aug 23, 2026
dc38d1c
Merge branch 'geocoder-php:master' into zero0cool0-fix-locationiq
zero0cool0 Sep 17, 2026
cdc22a1
test: add LocationIQ bounds test
Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Provider/LocationIQ/LocationIQ.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ private function xmlResultToArray(\DOMElement $resultNode, \DOMElement $addressN
if ($boundsAttr) {
$bounds = [];
list($bounds['south'], $bounds['north'], $bounds['west'], $bounds['east']) = explode(',', $boundsAttr);
$builder->setBounds((float) $bounds['south'], (float) $bounds['north'], (float) $bounds['west'], (float) $bounds['east']);
$builder->setBounds((float) $bounds['south'], (float) $bounds['west'], (float) $bounds['north'], (float) $bounds['east']);
}

return $builder->build();
Expand Down
35 changes: 35 additions & 0 deletions src/Provider/LocationIQ/Tests/LocationIQTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
use Geocoder\Collection;
use Geocoder\IntegrationTest\BaseTestCase;
use Geocoder\Location;
use Geocoder\Model\Address;
use Geocoder\Model\Bounds;
use Geocoder\Provider\LocationIQ\LocationIQ;
use Geocoder\Query\GeocodeQuery;
use Geocoder\Query\ReverseQuery;
Expand Down Expand Up @@ -87,4 +89,37 @@ public function testGetNodeStreetName(): void
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
$this->assertEquals('Rue Quincampoix', $result->getStreetName());
}

public function testCorrectBounds(): void
{
$provider = new LocationIQ($this->getHttpClient($_SERVER['LOCATIONIQ_API_KEY']), $_SERVER['LOCATIONIQ_API_KEY']);

$results = $provider->geocodeQuery(GeocodeQuery::create('10 Downing Street, London, United Kingdom'));

$this->assertInstanceOf(\Geocoder\Model\AddressCollection::class, $results);
$this->assertCount(1, $results);

/** @var Address $result */
$result = $results->first();

$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
$this->assertEquals('Downing Street', $result->getStreetName());
$this->assertEquals('United Kingdom', $result->getCountry()->getName());

/** @var Bounds $bounds */
$bounds = $result->getBounds();

$north = $bounds->getNorth();
$south = $bounds->getSouth();
$west = $bounds->getWest();
$east = $bounds->getEast();

$this->assertTrue($north > $south);
$this->assertTrue($east > $west);

$this->assertEqualsWithDelta(51.5033074, $south, 1E-6);
$this->assertEqualsWithDelta(51.5036913, $north, 1E-6);
$this->assertEqualsWithDelta(-0.1277991, $west, 1E-6);
$this->assertEqualsWithDelta(-0.1273088, $east, 1E-6);
}
}