Skip to content

Add information for Timeline plugin when no time dimension layer is selected in TOC #11959 - #12828

Merged
offtherailz merged 3 commits into
geosolutions-it:masterfrom
rowheat02:timeline-feedback
Aug 27, 2026
Merged

offtherailz merged 3 commits into
geosolutions-it:masterfrom
rowheat02:timeline-feedback

Conversation

@rowheat02

@rowheat02 rowheat02 commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

Description

Currently, if none of the time-enabled layers are hidden in the TOC, the timeline is not shown. But when there are two time-enabled layers and the selected one is disabled from the TOC. The snapping layer is still the previously selected one and it seems confusing. So now a warning icon with a tooltip is shown in such a case.
image

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

Issue

fixes #11959(gitub is not letting me link issue using Developement, so using keyword "fixes" to link the issue)
What is the current behavior?

No warning when a hidden layer on the TOC is the selected layer in the timeline

What is the new behavior?

Warning shown when a hidden layer is the selected layer in the timeline.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@rowheat02 rowheat02 added this to the 2026.02.02 milestone Aug 24, 2026
@rowheat02
rowheat02 requested a review from offtherailz August 24, 2026 09:35
@cla-bot cla-bot Bot added the CLA Ready label Aug 24, 2026

@offtherailz offtherailz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The issue description is obsolete please update
  • Please fix the translations (this is not referring to anything, the guide layer)

Comment thread web/client/translations/data.it-IT.json Outdated
Comment thread web/client/translations/data.fr-FR.json Outdated
Comment thread web/client/translations/data.es-ES.json Outdated
Comment thread web/client/translations/data.en-US.json Outdated
Comment thread web/client/translations/data.de-DE.json Outdated
@offtherailz offtherailz assigned rowheat02 and unassigned offtherailz Aug 27, 2026
Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
@offtherailz
offtherailz self-requested a review August 27, 2026 12:17
@offtherailz offtherailz added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch backport 2026.02.xx and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Aug 27, 2026
@offtherailz
offtherailz enabled auto-merge (squash) August 27, 2026 12:24
@offtherailz
offtherailz merged commit 9c7b453 into geosolutions-it:master Aug 27, 2026
26 of 27 checks passed
@offtherailz

Copy link
Copy Markdown
Member

tdipisa added a commit that referenced this pull request Sep 16, 2026
…elected in TOC #11959 (#12828) (#12839)

* show timeline warning when guide layer is hidden on toc

* Apply suggestions from code review



---------


(cherry picked from commit 9c7b453)

Co-authored-by: RowHeat <40065760+rowheat02@users.noreply.github.com>
Co-authored-by: Tobia Di Pisa <tobia.dipisa@geosolutionsgroup.com>
@ElenaGallo

Copy link
Copy Markdown
Contributor

@rowheat02 When the guide layer is selected again in the TOC, it becomes visible again in the timeline but a warning appears in the TOC saying that the layer was not loaded correctly.

timeline-issue.mp4

Regarding this point mentioned in the issue: #11959 (comment)
Could you please confirm whether it was decided to remove the Show/Hide Timeline button?

@rowheat02

Copy link
Copy Markdown
Contributor Author

Hi @ElenaGallo

@rowheat02 When the guide layer is selected again in the TOC, it becomes visible again in the timeline but a warning appears in the TOC saying that the layer was not loaded correctly.

In TOC, since the current time was applied from another layer(Meteorite...), so on that timestamp data may not be available for Boxes_with_time. If you select again box_with_time on timeline then it must work. So this behaviour is normal.

Screen.Recording.2026-09-22.at.14.15.22.mov

Regarding this point mentioned in the issue: #11959 (comment)
Could you please confirm whether it was decided to remove the Show/Hide Timeline button?

That comment was outdated.
That button was removed during this issue: #11926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add information for Timeline plugin when guide layer is hidden in TOC

3 participants