run handleLoad for containers requiring the same theme - #12884
Open
tha-nordiq wants to merge 1 commit into
Open
tha-nordiq wants to merge 1 commit into
tha-nordiq wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For secondary maps handleLoad is never run, therefore the loadAfterTheme option does not work.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#12872
What is the current behavior?
when multiple maps are embedded loadAfterTheme only works for whichever map is first in installing its theme.
What is the new behavior?
all maps work with loadAfterTheme
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)