Repository navigation
Require an explicit fetcher on the URL-based resolvers - #63
Merged
Merged
Conversation
Remove the URLSession.manualRedirect() defaults from DidWebResolver, DidPlcResolver, WellKnownHandleResolver and DnsHandleResolver, drop the unused FoundationNetworking imports, and require GermConvenience 0.13.0. The Android CI leg now scans the portable targets' objects for a FoundationNetworking autolink entry, with a positive control. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 86db505 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
germ-mark
marked this pull request as ready for review
October 1, 2026 06:51
germ-mark
marked this pull request as draft
October 1, 2026 07:07
DidWebResolver, DidPlcResolver and WellKnownHandleResolver now take an any RedirectRefusingHTTPFetcher (GermConvenience 0.14.0), so a redirect-following fetcher no longer compiles. StubHTTPFetcher conforms. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
URLSession.manualRedirect()defaults fromDidWebResolver,DidPlcResolver,WellKnownHandleResolverandDnsHandleResolver, so non-Apple platforms can depend on the fetcher-based API without reachingURLSession. NoURLSessiontarget is added: nothing in this package relied on the defaults.any RedirectRefusingHTTPFetcher(GermConvenience 0.14.0), so a redirect-following fetcher no longer compiles.DnsHandleResolvertakes aDNSTXTFetcher, unchanged in type.StubHTTPFetcherconforms toRedirectRefusingHTTPFetcher.FoundationNetworkingimports from the four resolver files.OnlineTestsdepends onGermConvenienceURLSession.-lFoundationNetworkingautolink entry, with a positive control on the test target.Test notes:
swift teston macOS (112 tests) passes; strictswift format lintclean; Android (aarch64, Swift 6.4) cross-build ofAtprotoClientandAtprotoClientMockspasses the scan, and the control is detected. Linux and Android CI to confirm.🤖 Generated with Claude Code