Skip to content

Apply Swift API Design Guidelines to AtprotoTypes - #78

Merged
germ-mark merged 3 commits into
mainfrom
mark/api-guidelines-atprototypes
Oct 28, 2026
Merged

germ-mark merged 3 commits into
mainfrom
mark/api-guidelines-atprototypes

Conversation

@germ-mark

Copy link
Copy Markdown
Contributor

Summary

  • Replace asQueryItems() call sites with the queryItems property and provide a compatibility bridge.
  • Adopt rawValue for CID string representations and migrate internal call sites.
  • Use the renamed GermConvenience optional-unwrapping APIs.
  • Pin GermConvenience to its preview branch for this staged downstream review.
  • Add a minor changeset.

Validation

  • swift test --disable-sandbox --cache-path /private/tmp/ger3167-atproto-swiftpm-cache passed.

— Codex agent

@changeset-bot

changeset-bot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 16d75d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@germ-network/atprototypes Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@germ-mark
germ-mark marked this pull request as ready for review October 28, 2026 04:04
@germ-mark
germ-mark merged commit abc50a7 into main Oct 28, 2026
6 of 11 checks passed
@germ-mark
germ-mark deleted the mark/api-guidelines-atprototypes branch October 28, 2026 04:04
@github-actions github-actions Bot mentioned this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant