docs: record the second half of the closing-keyword trap - #712
Merged
Conversation
The HANDOFF entry added one commit ago described how a stale closing keyword in a squashed commit message shut an unfixed issue. Writing that description shut the same issue a second time: the sentence documenting the trap contained the keyword, and GitHub parses it anywhere in a commit message, prose context included. Both halves are now recorded, with the remedy: refer to such an issue as `issue NNN`, or keep the verb and the number in different clauses, and check `gh issue view <n> --json state` after any merge whose scope changed mid-flight. Issue 706 has been reopened, again. It remains unfixed and is very likely subsumed by #710. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016SFzA2sTh2EpX8MZU3TWNS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HANDOFF entry added in #711 described how a stale closing keyword in a squashed commit message shut an unfixed issue.
Writing that description shut the same issue a second time. The commit message documenting the trap contained the sentence "This closed #706 while it was unfixed" — and GitHub parses that keyword anywhere in a commit message, prose context included.
Both halves are now recorded, with the remedy: refer to such an issue as
issue NNN, or keep the verb and the number in different clauses. And checkgh issue view <n> --json stateafter any merge whose scope changed mid-flight — nothing warns you, and a ledger row can quietly end up pointing at a closed issue.Issue 706 is reopened, again. It remains unfixed and is very likely subsumed by #710.
Docs only.
🤖 Generated with Claude Code
https://claude.ai/code/session_016SFzA2sTh2EpX8MZU3TWNS