Skip to content

chore(deps): Bump node from 20-slim to 25-slim in /docker - #156

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/docker/docker/node-25-slim
Closed

chore(deps): Bump node from 20-slim to 25-slim in /docker#156
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/docker/docker/node-25-slim

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bumps node from 20-slim to 25-slim.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps node from 20-slim to 25-slim.

---
updated-dependencies:
- dependency-name: node
  dependency-version: 25-slim
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file docker Pull requests that update docker code labels Aug 6, 2026
@dependabot
dependabot Bot requested a review from pofallon as a code owner August 6, 2026 20:34
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file docker Pull requests that update docker code labels Aug 6, 2026
@pofallon

pofallon commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Closing in favor of #161, which moves the base image to node:24-slim instead.

node:25-slim is end-of-life. Per Node's schedule.json, 25 is an odd-numbered "Current" release that never becomes LTS and reached EOL on 2026-06-01 — so this bump would have swapped one unpatched base image (20, EOL 2026-04-30) for another, which is the exact failure the docker ecosystem entry added in #154 exists to prevent.

Node 24 (Krypton) is Active LTS through 2028-04-30. #161 makes that move, and also updates CI's setup-node pin and the hardcoded node:20-slim strings in tests/image/ that a one-line bump leaves stale.

Not your fault, Dependabot — you pick the highest tag and have no concept of Node's release lines. #161 adds a semver-major ignore for node so majors get picked by hand on the LTS cadence; minor/patch bumps keep flowing.

@pofallon pofallon closed this Aug 7, 2026
@dependabot @github

dependabot Bot commented on behalf of github Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/docker/docker/node-25-slim branch August 7, 2026 00:54
pofallon added a commit that referenced this pull request Aug 7, 2026
The frontend-builder stage sat on node:20-slim, which went EOL on
2026-04-30 and no longer receives security patches. Dependabot noticed and
proposed node:25-slim (#156) -- but 25 is an odd-numbered "Current" release
that never becomes LTS and reached EOL on 2026-06-01, so that bump swapped
one unpatched base image for another. Node 24 (Krypton) is Active LTS:
supported until 2028-04-30, and it does not even enter maintenance until
2026-10-20.

Dependabot picks the highest published tag and has no concept of Node's
release lines, so it will keep proposing odd majors (26 arrives 2026-10-28,
27 a year later). Ignore semver-major bumps for `node` in the docker
ecosystem and pick Node majors by hand on the LTS cadence; minor/patch
bumps, which carry the base-image CVE fixes this ecosystem entry was added
for, keep flowing untouched.

CI's setup-node pin moves 20 -> 24 in the same change: left behind, it would
typecheck and build the frontend on a different major than the shipped image
builds it with. The two `node:20-slim` strings in
tests/image/test_docker_image.py and the one in dependabot.yml's own comment
are updated to match.

Supersedes #156.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file docker Pull requests that update docker code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant