fix(release): correct v2.6.0 checksums and stop the job hiding its failure - #165
Merged
Conversation
…ilure
`brew install Anandb71/tap/arbor` was broken on v2.6.0. The formula still
carried the v2.5.0 checksums, and the Scoop manifest advertised 2.6.0 while
its download URL still pointed at the v2.5.0 zip.
The release workflow's checksum job reported success while doing nothing. Its
final line was:
git push origin main || echo "::warning::Could not push to main..."
`main` requires a pull request, so that push always fails — and `|| echo`
turned the failure into a green job. Every release since branch protection was
enabled has shipped the previous version's checksums.
Two fixes to the workflow:
- The push step now tries main, falls back to opening a PR, and *fails* if
neither works. A green job must mean the manifests were actually updated.
- The Scoop download URL is rewritten to the release version. Only the
`version` field and hash were being updated, so the manifest pointed at the
wrong asset regardless of the checksum.
All five checksums in this commit were computed from the published v2.6.0
release assets and verified against them:
macos-aarch64 733d2b9e…
macos-x86_64 9de570cf…
linux-aarch64 7ef21230…
linux-x86_64 9a84fc66…
windows-x86_64 72877177…
⚪ Arbor PR Walk
No code symbols detected in changed files — this looks like a docs, config, or generated-code change. 📊 Analysis confidence: Low · 1727 nodes · 8109ms
Suggestions to improve accuracy:
Arbor · View full report → · arbor v2.5.0 · 8109ms · 1727 nodes · verify locally with |
🌳 Arbor Impact ReportRisk Level: 🟢 Low | Blast Radius: 0 nodes | Changed Symbols: 2 Changed Files
📊 Visual Impact Graphgraph TD
classDef changed fill:#ef4444,stroke:#333,stroke-width:2px,color:#fff;
classDef caller fill:#f59e0b,stroke:#333,stroke-width:1px,color:#fff;
class install changed;
class Arbor changed;
Impact Summary
Powered by Arbor v2.6.0 — graph-native code intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew installis currently broken on v2.6.0 — the formula carries v2.5.0 checksums, and the Scoop manifest points at the v2.5.0 zip.Root cause: the release workflow's checksum job ended in
git push origin main || echo "::warning::". Sincemainrequires a PR, that push always fails, and|| echoturned it into a green job. Every release since branch protection was enabled has shipped the previous version's checksums.Fixes the workflow to fall back to opening a PR and to fail if it cannot, and to rewrite the Scoop download URL (previously only the version field and hash were updated).
All five checksums here were computed from the published v2.6.0 assets and verified against them.