fix: EULA always English, expand content, BMS logo, window title#33
Merged
Conversation
- Hardcode all EULA UI strings in English (title, buttons, labels, dialogs) so the agreement is always displayed in English regardless of the selected app language - legal documents must be consistent - Replace briefcase icon in header with the actual BMS SVG logo - Expand EULA text from 10 to 15 sections covering: definitions, license tiers, restrictions, IP ownership, license key enforcement, data privacy, updates, warranty disclaimer, liability cap, indemnification, termination, governing law, severability, and entire agreement - Remove l10n dependency from EulaScreen (no longer uses context.l10n)
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe app title is updated to "BMS - Business Management System" in the Flutter ChangesBMS Title and EULA Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Preview deployed
Updates automatically on every push. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 12: The CHANGELOG.md entry on line 12 mentions a "Contact clause" as one
of the five new sections added to the EULA, but this clause does not actually
exist in the updated EULA content. Remove the reference to "Contact clauses"
from the changelog entry to ensure the documented changes accurately reflect the
actual EULA sections that were added. Update the text to only list the sections
that are present in the new EULA version.
In `@lib/features/eula/presentation/eula_screen.dart`:
- Around line 378-403: The Row widgets containing Text elements with hardcoded
strings ('You have read the full agreement' and 'Scroll to the bottom to enable
acceptance') will overflow on narrow screen widths instead of wrapping the text.
Wrap each Text widget in a Flexible widget to constrain the text width and allow
it to wrap properly on smaller screens, ensuring the layout adapts correctly
across all device sizes without overflow.
- Around line 96-101: The EULA text in section 7.2 on eula_screen.dart claims
the SQLite database is encrypted, but the actual implementation in
app_database.dart uses standard unencrypted Drift/SQLite with only WAL and
foreign key pragmas enabled (no encryption pragmas like PRAGMA key or sqlcipher
configuration). To resolve this discrepancy, either implement database
encryption in app_database.dart using sqlcipher or native encryption options, or
update the EULA text in eula_screen.dart section 7.2 to accurately state that
data is stored locally but not encrypted at the database level. This legal and
privacy compliance issue must be resolved before release.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5ce31e64-4486-4851-88b4-f13a7fe2d013
📒 Files selected for processing (5)
CHANGELOG.mdlib/app.dartlib/features/eula/presentation/eula_screen.dartmacos/Runner/Configs/AppInfo.xcconfigwindows/runner/Runner.rc
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Contributor
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 1 file(s) based on 2 unresolved review comments. Files modified:
Commit: The changes have been pushed to the Time taken: |
hiranyasemindi
approved these changes
Jun 22, 2026
Fixed 1 file(s) based on 2 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
hiranyasemindi
approved these changes
Jun 22, 2026
…Name Changing PRODUCT_NAME renamed the bundle from bms.app to 'BMS - Business Management System.app', breaking the CI codesign step. Keep PRODUCT_NAME = bms so the bundle filename stays bms.app, and set CFBundleDisplayName in Info.plist so Finder and the Dock show the full product name.
hiranyasemindi
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three issues found after Phase 7 merge: the EULA screen was showing in the user's selected language instead of English, the header used a placeholder icon instead of the BMS logo, and the window title bar showed 'bms' on both macOS and Windows.
Type
Changes
Icons.business_centerin the EULA header withSvgPicture.asset('assets/images/bms_logo.svg')at 40x40AppInfo.xcconfigand on Windows viaRunner.rc;MaterialApp.titleupdated to matchScreenshots
Before: EULA header in Tamil, briefcase icon, window title 'bms'
After: EULA always in English with BMS SVG logo, window title 'BMS - Business Management System'
Test plan
Related issues
Summary by CodeRabbit
Release Notes
Bug Fixes
New Features