-
Notifications
You must be signed in to change notification settings - Fork 2
fix: macOS persistence, MySQL UUID keys, file picker blackout, and settings card color #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
683b8d9
fix: use VARCHAR(36) for UUID columns in MySQL DDL generation
iamvirul 3536ddf
fix: switch EULA storage to file, add keychain entitlements for macOS
iamvirul e1bf787
fix: add 100ms delay before file picker to prevent macOS blackout
iamvirul 2153144
fix: unify backend card background color with text field fill
iamvirul 407c0fd
fix: apply CodeRabbit review findings on eula and keychain options
iamvirul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,36 @@ | ||
| import 'package:bms/core/constants/app_constants.dart'; | ||
| import 'dart:io'; | ||
|
|
||
| import 'package:flutter/foundation.dart' show kIsWeb; | ||
| import 'package:flutter_riverpod/flutter_riverpod.dart'; | ||
| import 'package:flutter_secure_storage/flutter_secure_storage.dart'; | ||
| import 'package:path_provider/path_provider.dart'; | ||
|
|
||
| // EULA acceptance is not sensitive data - store as a plain marker file rather | ||
| // than in the Keychain to avoid macOS password prompts on every launch. | ||
| class EulaNotifier extends AsyncNotifier<bool> { | ||
| static const _storage = FlutterSecureStorage(); | ||
|
|
||
| @override | ||
| Future<bool> build() async { | ||
| // On web we skip the EULA gate (demo/preview builds). | ||
| if (kIsWeb) return true; | ||
|
|
||
| try { | ||
| final value = await _storage.read(key: AppConstants.eulaStorageKey); | ||
| return value != null; | ||
| return (await _markerFile()).existsSync(); | ||
| } catch (_) { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| Future<void> accept() async { | ||
| try { | ||
| await _storage.write( | ||
| key: AppConstants.eulaStorageKey, | ||
| value: DateTime.now().toUtc().toIso8601String(), | ||
| ); | ||
| } catch (_) {} | ||
| final file = await _markerFile(); | ||
| await file.writeAsString(DateTime.now().toUtc().toIso8601String()); | ||
| } catch (_) { | ||
| return; | ||
| } | ||
| state = const AsyncData(true); | ||
| } | ||
|
|
||
| static Future<File> _markerFile() async { | ||
| final dir = await getApplicationSupportDirectory(); | ||
| return File('${dir.path}/.eula_accepted'); | ||
| } | ||
| } | ||
|
|
||
| final eulaProvider = AsyncNotifierProvider<EulaNotifier, bool>(EulaNotifier.new); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.