Fix false max-turns detection in Codex output - #22
Merged
Conversation
Match Claude's turn-limit diagnostic as a complete line and skip harnesses that cannot pass --max-turns. Substring scans of Codex tool transcripts were classifying this repo's own source and lint dumps as max-turns exhaustion. Signed-off-by: devintern-internal[bot] <4622575+devintern-internal[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same class of false positive as #15 (usage-limit detection). DEV-70's Codex run finished the Turborepo work, then DevIntern classified it as max-turns exhaustion because the detector substring-matched this repo's own source and oxlint dumps (
due to max turns reached...).Error: Reached max turns (N)(and close variants) to match a complete diagnostic line, not an arbitrary transcript substring--max-turns(today only Claude Code setssupportsMaxTurns)Why not stderr-only
#15 already rejected "stderr is diagnostic." Codex exec dumps command/tool output on stderr. The DEV-70 false positive lived in that transcript.
Verification