fix(code): skip doomed master fetches when --pr-target-branch is stale - #23
Merged
Conversation
![devintern-internal[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
DEV-74 only resolved the default branch when --pr-target-branch was omitted. Cron examples (and copied systemd units) pass --pr-target-branch master, so startup still ran git fetch origin master on main-only repos before falling back. Resolve a missing explicit target first, and stop pullLatestChanges from fetching a ref the remote does not have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--pr-target-branchwas omitted. Copied cron/systemd examples still pass--pr-target-branch master, so startup rangit fetch origin masteronmain-only repos and only then fell back.pullLatestChanges) against the remote first, so a stalemaster/mainflag never issues a doomed fetch.--pr-target-branch masterfrom the documented cron/systemd examples; omit the flag unless targeting a non-default branch.Test plan
bun run --filter @getdevintern/code test default-branch-detection.test.ts pull-latest-changes.test.ts--pr-target-branch masteron this repo logs a fallback tomainand does not printfatal: couldn't find remote ref master--pr-target-branchstill printsDefault branch detected as 'main'and pullsmain