fix(scss): declare theme-mode-transition default at point of use#2001
Merged
Conversation
Child themes commonly shadow common/_variables.scss with a fork, which silently drops variables added upstream and breaks the Sass compile with an undefined variable. Declaring the !default at the consuming files keeps the build self-sufficient while a fork that does define the variable still wins. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for gethinode-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
🎉 This PR is included in version 2.19.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Child themes commonly ship their own fork of
common/_variables.scss/_variables-dart.scss, which shadows hinode's copy in Hugo's union filesystem. Any variable added upstream to that file silently disappears from such themes, and the Sass compile fails with an undefined variable the moment a component references it.This happened with
$theme-mode-transition(added in 34bcd18): downstream theme-infusal broke on the v2.15.1 → v2.19.3 bump withFix
Declare the
!defaultat the two consuming files (common/_styles.scss,components/_navbar.scss) so the compile is self-sufficient regardless of what the child theme's variables fork contains. A fork that does define the variable still wins through!defaultsemantics; CSS output is unchanged.Verification
🤖 Generated with Claude Code