Skip to content

fix: restore v5 rendering parity for video-message and hero #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markdumay merged 2 commits into from
Jul 13, 2026
+6 −2
Merged

fix: restore v5 rendering parity for video-message and hero #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8328e62
fix(video-message): restore gutterless message list
markdumay Jul 13, 2026
02e3ac7
fix(hero): restore local fallback for heading width
markdumay Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions component-library/components/video-message/video-message.hugo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,12 @@
{{ $iconRounded := .iconRounded }}
{{ $iconStyle := .iconStyle }}

{{/* gutter 0 suppresses the g-* class entirely (with-guard treats 0 as unset),
preserving the v1 message rhythm: default horizontal gutters, no vertical gap */}}
{{- partial "assets/card-group.html" (dict
"page" page
"list" $list
"gutter" 0
"class" "border-0 card-icon card-icon-secondary"
"cols" $cols
"padding" "0"
Expand Down
5 changes: 3 additions & 2 deletions layouts/partials/assets/hero.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@
Only applies to horizontal orientation; stacked uses $scale for the image wrapper instead. */}}
{{ $imgColWidth := 12 }}
{{ if eq $args.orientation "horizontal" }}
{{/* heading.width is filled by the argument engine (default 8) at any nesting depth */}}
{{ $imgColWidth = sub 12 $args.heading.width }}
{{/* keep a local fallback: heading.width carries no engine default (suppressed
at the type level so section titles and images span their columns) */}}
{{ $imgColWidth = sub 12 (or $args.heading.width 8) }}
{{ if lt $imgColWidth 1 }}{{ $imgColWidth = 1 }}{{ end }}
{{ end }}

Expand Down
Loading