feat!: adopt mod-utils v6 (mod-simple-datatables v4)#272
Merged
Conversation
Bumps the module's own Go path to /v4 and the mod-utils requirement to v6.0.1, matching the mod-utils v6 adoption program's pinned-version requirement (v6.0.0 carries a known camelKey defect, fixed in v6.0.1). This module ships no Hugo templates of its own (no layouts/ directory; only JS/SCSS assets, i18n strings, and Bootstrap-table markup consumed by the exampleSite) and has no InitArgs.html/InitTypes.html call sites to migrate to the Args API, confirmed via a repo-wide grep and directory listing. The mod-utils requirement is transitive only (declared indirect in go.mod), inherited by any site that also imports mod-utils directly. exampleSite/go.mod's self-referencing require line is left empty, matching the mod-fontawesome v6 precedent: the v4.0.0 tag does not exist until this PR merges and releases, so pinning it would break hugo mod vendor / go list -m resolution in CI. Hugo's workspace file (mod-simple-datatables.work, use ../) resolves the self import from local disk via hugo.toml's module.imports path instead. Verified: hugo mod graph (exampleSite context) shows only mod-utils/v6@v6.0.1, zero /v5 references; pnpm build exits 0 with zero ERROR lines and only pre-existing, unrelated WARN lines (deprecated languageCode/includeFiles/libsass, the module's own intentional JS-bundling warnf); visual regression is 104/104 clean (0.0000% diff on every page) against the module's own exampleSite baseline, as expected for a dependency-only version bump. BREAKING CHANGE: requires github.com/gethinode/mod-simple-datatables/v4 import path; adopts mod-utils v6 and migrates argument handling to the Args API (see gethinode/mod-utils v5-to-v6 migration notes). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts mod-utils v6 (gethinode/mod-utils#334, with the v6.0.1 camelKey-collision fix, gethinode/mod-utils#335), as this module's own major release (v3 → v4). This is a wave-1 module for the mod-utils v6 adoption program.
github.com/gethinode/mod-simple-datatables/v3→/v4;mod-utilsrequirement bumped directly tov6.0.1(neverv6.0.0, which carries a known camelKey defect fixed in.1).config.toml,exampleSite/hugo.toml,exampleSite/go.modupdated to the new major.mod-bootstrapis untouched (it does not depend on mod-utils).exampleSite/go.mod(matching the mod-fontawesome v6 PR's precedent): thev4.0.0tag does not exist until this PR merges and releases, so pinning it would breakhugo mod vendor/go list -mresolution both locally and in CI. Hugo's workspace file (mod-simple-datatables.work,use ../) resolves the self-import from local disk viahugo.toml'smodule.importspath instead —hugo mod graphconfirms the resolved graph is correct (see below).exampleSite/go.sumandexampleSite/mod-simple-datatables.work.sumare consequently empty/absent, matching what an empty require block implies.Argument handling migration (recipe step 4)
No call sites to migrate. This module ships no Hugo templates of its own — there is no
layouts/directory at all (confirmed via a repo-wide grep forInitArgs/InitTypesand a full directory listing). It only mounts JS (simple-datatables.js), SCSS, andi18nstrings that Hinode's owntableshortcode/partial consumes at the markup level viadata-table-*attributes. Themod-utilsrequirement is transitive only (// indirectingo.mod), inherited by any site that also importsmod-utilsdirectly (e.g. Hinode itself). Nothing in this module callsArgs.html/InitArgs.html/InitTypes.html, so there is no strict-false guardrail to add and no| default/or-on-Args-value pattern to grep for.Test plan
hugo mod graph(exampleSite context) showsmod-simple-datatables/v4 → mod-utils/v6@v6.0.1, zero/v5references anywhere in the graphpnpm build(hugo --gc --minify -s exampleSite) exits 0 with zero ERROR lines, 109 pages built (unchanged from the pre-bump baseline)languageCodeconfig key, deprecatedmodule.mounts.includeFiles, deprecatedlibsass, and the module's own intentionalwarnfJS-bundling diagnostics. None are new; none are attributable tomod-utils/self-path.tests/visual/on the hinodeprogram/mod-utils-v6-adoptionbranch), 104/104 pages compared, 0 flagged, 0.0000% diff ratio on every page — expected, since this is a dependency-version-only change with no template call sites that could alter rendered output.git diffreviewed file-by-file; no unrelated changes🤖 Generated with Claude Code