fix: suppress inherited defaults on shared layout members#340
Merged
Conversation
The global argument defaults leak into shared user-defined types once v6 applies nested member defaults, overriding downstream fallbacks that expect absence (v5 semantics). Suppressed via explicit nil defaults, with per-member rationale comments: heading.width and illustration.width (text-column default shrinks images and compounds with section widths), illustration.justify and links.outline plus links.order (downstream partials layer their own defaults, e.g. download buttons render outlined by design), and the styles member overrides width, orientation, and portrait (per-style values must fall back to card-group context). Verified against production markup for about, heading, hero, featured, and video-message pages plus a 59-page structural sweep. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
🎉 This PR is included in version 6.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual-review outcome from validating the v6 generation against gethinode.com's block/component library: global argument defaults leak into shared type members and override downstream fallbacks that expect absence (v5 semantics). Suppresses eight members via explicit nil defaults (heading.width, illustration.width/justify, links.outline/order, styles.width/orientation/portrait), each with a rationale comment. Goldens 13/13 green; verified against production markup plus a 59-page structural sweep (classes and data attributes).
Note: merge gethinode/mod-blocks#150 first — it restores mod-blocks' local hero width fallback that this suppression would otherwise expose.
🤖 Generated with Claude Code