fix(arguments): drop the wrap/data-table incompatibility note#344
Merged
Conversation
The wrap argument's comment claimed "This setting is not compatible with data tables." That is no longer true: Hinode renders a wrapped data table uniformly and mod-simple-datatables applies the wrapped layout through simple-datatables' tableRender hook, so wrap combines with sortable, paginate and searchable. The stale note is surfaced in the generated argument documentation, so it needs a release to reach downstream sites.
markdumay
force-pushed
the
docs/table-wrap-datatables
branch
from
57ec0ac to
64c928f
Compare
markdumay
changed the title
Collaborator
Author
|
🎉 This PR is included in version 6.4.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
wrapargument's comment claimed "This setting is not compatible with data tables." That is no longer true: Hinode now renders a wrapped data table uniformly and mod-simple-datatables applies the wrapped layout through simple-datatables'tableRenderhook, sowrapcombines withsortable,paginateandsearchable.Typed
fixrather thandocsdeliberately: the comment feeds the generated argument documentation, so it needs a release (v6.4.0 → v6.4.1) to reach downstream sites. The companion PRs will then pick up the bump.Companion to gethinode/hinode#2018 and gethinode/mod-simple-datatables#277.
🤖 Generated with Claude Code