docs(ci): correct the include-hidden-files rationale in docs.yml - #318
Conversation
The comment added in 7c4827b claims Docusaurus writes a `.nojekyll` into website/build, and justifies `include-hidden-files: true` as restoring it. That is wrong: Docusaurus only writes `.nojekyll` from its own `deploy` command, not from a plain `build`. The Pages artifact published by that very commit (id 9028339047) was unpacked and contains 59 entries and no dot-entries at all, so the flag is currently a no-op. Keep the flag, fix the reason. Preserving the v3 default matters for what comes later, not for what is there now: a `.well-known/` added for domain verification or security.txt would be dropped from the deploy silently under the v4+ default, and that failure is invisible until someone checks why the verification never completes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 11 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The comment I added in #316 (
7c4827b9) states:That is wrong. Docusaurus writes
.nojekyllfrom its owndeploycommand, not from a plainbuild. This site runsnpm run buildand deploys the artifact, so no.nojekyllis ever produced.Verified rather than assumed — the Pages artifact published by that very commit (id
9028339047) was downloaded and unpacked:So
include-hidden-files: trueis currently a no-op, and the risk I used to justify splittingdocs.ymlout of #97 did not actually exist.Fix
Keep the flag, correct the reason.
The value is forward-looking, not current: a
.well-known/directory added later for domain verification orsecurity.txtwould be dropped from the deploy silently under the v4+ default. That is the failure worth guarding — it is invisible until someone wonders why a verification never completes.No behavior change; this touches a comment only.
Note
The Pages deploy on
mainafter #316 succeeded end to end —Build siteandDeploy to GitHub Pagesboth green, https://getopenscreen.com/ serving200, and zero Node 20 deprecation lines in the run. The bump itself is fine; only its stated rationale was off.🤖 Generated with Claude Code